search

digitalcredentials / learner-credential-wallet

Learner Credential Wallet is a cross-platform iOS and Android mobile application for storing and sharing digital learner credentials.
https://lcw.app
MIT License
58 stars 29 forks source link

Moved Issuance Date and Expiration Date to be in a row together #495

Closed jennacioffi closed 1 year ago

jennacioffi commented 1 year ago

Issuance and Expiration dates are now in a row Issue: https://github.com/digitalcredentials/learner-credential-wallet/issues/486

jennacioffi commented 1 year ago

@dmitrizagidulin please note lint is failing due to the node_modules/ issue I messaged about in Slack

dmitrizagidulin commented 1 year ago

@dmitrizagidulin please note lint is failing due to the node_modules/ issue I messaged about in Slack

Er, wait, but the one lint issued listed has to do with this app's source code, not node_modules.

jennacioffi commented 1 year ago

@dmitrizagidulin please note lint is failing due to the node_modules/ issue I messaged about in Slack

Er, wait, but the one lint issued listed has to do with this app's source code, not node_modules.

The errors I'm seeing are the following:

Error: node_modules/@react-navigation/core/lib/typescript/src/types.d.ts(510,120): error TS1005: '?' expected.
Error: node_modules/@reduxjs/toolkit/dist/createSlice.d.ts(128,125): error TS1005: '?' expected.
Error: node_modules/@reduxjs/toolkit/dist/createSlice.d.ts(128,154): error TS1005: ';' expected.
Error: node_modules/@types/node/ts4.8/test.d.ts(831,34): error TS1005: '?' expected.
Error: node_modules/@types/node/ts4.8/test.d.ts(832,17): error TS1005: ':' expected.
Error: node_modules/@types/node/ts4.8/test.d.ts(833,17): error TS1005: ',' expected.
Error: node_modules/@types/node/ts4.8/test.d.ts(836,34): error TS1005: '?' expected.
Error: node_modules/@types/node/ts4.8/test.d.ts(837,17): error TS1005: ':' expected.
Error: node_modules/@types/node/ts4.8/test.d.ts(838,17): error TS1005: ',' expected.
Error: node_modules/@types/node/ts4.8/test.d.ts(838,26): error TS1005: ',' expected.
Error: node_modules/@types/node/ts4.8/test.d.ts(839,5): error TS1109: Expression expected.
Error: node_modules/@types/node/ts4.8/test.d.ts(843,24): error TS1005: ',' expected.
Error: node_modules/@types/node/ts4.8/test.d.ts(847,35): error TS1005: ',' expected.
Error: node_modules/@types/node/ts4.8/test.d.ts(853,39): error TS1005: ',' expected.
Error: node_modules/@types/node/ts4.8/test.d.ts(857,21): error TS1005: ',' expected.
Error: node_modules/@types/node/ts4.8/test.d.ts(862,[19](https://github.com/digitalcredentials/learner-credential-wallet/actions/runs/5953636931/job/16148345017?pr=495#step:6:20)): error TS1005: ',' expected.
Error: node_modules/@types/node/ts4.8/test.d.ts(862,27): error TS1005: ':' expected.
Error: node_modules/@types/node/ts4.8/test.d.ts(862,36): error TS1005: ',' expected.
Error: node_modules/@types/node/ts4.8/test.d.ts(862,55): error TS1005: '{' expected.
Error: node_modules/@types/node/ts4.8/test.d.ts(862,64): error TS1005: ',' expected.
Error: node_modules/@types/node/ts4.8/test.d.ts(862,77): error TS1005: ',' expected.
Error: node_modules/@types/node/ts4.8/test.d.ts(866,[22](https://github.com/digitalcredentials/learner-credential-wallet/actions/runs/5953636931/job/16148345017?pr=495#step:6:23)): error TS1005: ',' expected.
Error: Process completed with exit code 2.

all which start with node_modules/ which are generated and so I am unsure how to modify lint to ignore these? (or am I misunderstanding you by chance?) @dmitrizagidulin

dmitrizagidulin commented 1 year ago

@jmcioffi4 ohh I see. Yeah, I'm looking at Github's linting in the 'Files changed' tab. And you're right, the 'lint' CI action isn't even getting that far.