search

digitalcredentials / learner-credential-wallet

Learner Credential Wallet is a cross-platform iOS and Android mobile application for storing and sharing digital learner credentials.
https://lcw.app
MIT License
54 stars 28 forks source link

(Issue #518) SVG to PDF conversion code #523

Closed jennacioffi closed 10 months ago

jennacioffi commented 10 months ago

Issue: https://github.com/digitalcredentials/learner-credential-wallet/issues/518

Note: The top value to fill in (CredentialSubject.name) seems off center but we have applied no styling changes so I am not sure why this occurs.


Screenshot 2023-10-25 at 12 41 24 PM


Screenshot 2023-10-25 at 12 41 36 PM


Screenshot 2023-10-25 at 12 41 57 PM

jennacioffi commented 10 months ago

@kayaelle @dmitrizagidulin we need to talk about the dynamic part (handlebars) in our next meeting before we can account for that

jennacioffi commented 10 months ago

App properly converts valid handlebars into the pdf (the other two handlebars data is not in here because they are improperly labeled/named in the svg template):

Screenshot 2023-10-30 at 3 22 01 PM

jennacioffi commented 10 months ago

@dmitrizagidulin @kayaelle ready for review.

NOTE: The logic was moved to app/lib/svgToPdf.ts and we will move this into a separate repo sometime this week :) - just let us know when you have a git repo created for us to put it in :)

jennacioffi commented 10 months ago

@dmitrizagidulin Tested and this works still so you can merge following the steps github tells you to manage to rebase it

dmitrizagidulin commented 10 months ago

Conflicts resolved, merging and releasing for testing.