digitalcredentials / learner-credential-wallet

Learner Credential Wallet is a cross-platform iOS and Android mobile application for storing and sharing digital learner credentials.
https://lcw.app
MIT License
56 stars 29 forks source link

vc.verifyCredential not working with Participate credential that don't have credentialStatus property #644

Closed alexfigtree closed 1 week ago

alexfigtree commented 1 week ago

Describe the bug vc.verifyCredential not working with Participate credential that don't have credentialStatus property - does not verify

To Reproduce In LCW, try and verify this credential:

{ "@context": [ "https://www.w3.org/ns/credentials/v2" ], "type": [ "VerifiablePresentation" ], "verifiableCredential": [ { "@context": [ "https://www.w3.org/2018/credentials/v1", "https://purl.imsglobal.org/spec/ob/v3p0/context-3.0.3.json", "https://w3id.org/security/suites/ed25519-2020/v1" ], "credentialSubject": { "achievement": { "criteria": { "narrative": "Successful completion of this certification requires passing of a comprehensive assessment of job readiness skills by qualified IRC staff. Assessment mechanisms for each module are outlines above. Individuals are scored by two IRC staff members on a detailed rubric with a 0-3 scale for each piece of the assessment. Recipients of this certificate have scored an overall 2 or higher, reflecting successful demonstration of requisite skills.", "type": "Criteria" }, "description": "The recipient of this credential has been trained in best practices in workplace culture in the U.S. including communication and navigating common human resources systems, searching and applying for jobs including developing interview skills, and best practices in starting a job including completing onboarding procedures and understanding workplace safety and rights. The recipient has practiced these skills through vocabulary activities, speaking and communication practice activities, role play activities, resume writing and job search activities, and interview practice and training. The recipient has demonstrated these competencies through oral and written comprehension assessments, a mock interview assessment, a job application practical examination, and an on-the-job role play assessment. Job Readiness Training for New Americans is a 6-module curriculum delivered by trained IRC instructors and is designed to ensure that individuals have a strong foundation of work skills that can reinforce job success and retention.\n\nCompetencies & Skills Attained: Proficient Understanding of US Work Culture & Professional Attire, Effective Communication Skills, Demonstrated Reliability, Demonstrated Punctuality & Time Management Skills in the Workplace, Adaptive Attitude and Receptive to Feedback, and Team Collaboration", "id": "urn:uuid:0a2e4e7a-37b6-4aa0-a4b4-e94ae421ec64", "image": { "id": "https://participate.community/img/k/public/f44d3be-Badge%20%281%29.png", "type": "Image" }, "name": "Job Readiness Training for New Americans", "type": [ "Achievement" ] }, "id": "did:key:z6MkszTWWKdsKdYaETT2wxtJ4GfMdPaYsMVXqmo8ieVgCuTB", "type": [ "AchievementSubject" ] }, "id": "https://participate.community/open-badges/v2/assertions/5d66dbc3-3a4f-41a9-92c9-7d1c89068bde", "issuanceDate": "2024-05-08T19:33:23.204534Z", "issuer": { "id": "did:web:participate.community", "image": { "id": "https://participate.community/img/k/public/6e2d9d0-V2%20Community%20Logos%20%284%29.png", "type": "Image" }, "name": "International Rescue Committee", "type": [ "Profile" ], "url": "https://www.rescue.org/" }, "name": "Job Readiness Training for New Americans", "proof": [ { "created": "2024-10-07T14:08:35Z", "proofPurpose": "assertionMethod", "proofValue": "z22yPh4Xb38AR21qYQyDDgq3E7dMja5eeSsYgA9kkvfmeK2GVgA2LDfiMqVdLB24qNG9q2Zexb1jKexRFA6ZXebSk", "type": "Ed25519Signature2020", "verificationMethod": "did:web:participate.community#z6MkshUuBLUq8B3heEMCNNbxEMadoWSgiDhSt6b2iA9Nozqu" } ], "type": [ "VerifiableCredential", "OpenBadgeCredential" ] } ] }

Expected behavior Should return a credential even if it doesn't have a 'credentialStatus' property.

Desktop (please complete the following information):

alexfigtree commented 1 week ago

Moved to prod 2.1.3 both iOS and Android