feat: verify first, check semantics after and remove issuanceDate check

[lleifermann]

This PR proposes the some changes as discussed in: https://github.com/digitalcredentials/vc/issues/7

• Verify Presenation Proof & Credential Proof FIRST before doing any semantic checks as the fields may be tampered with.
• Remove check if issuanceDate is not in the future as this is a fully expected use-case (to issue credentials that become valid at some point in time)

IMHO we should also remove the check (if not even all of them) if a credential is expired when issuing it. For some e2e test scenarios one may choose to issue an expired credential.

I am still a bit confused. Initally my PR was larger, with more modifications to error handling as well. But it seems jsigs already does alot of sanity and semantic checks on the credential (checking if a context is there for example). Is there a reason we do them again here?

[lleifermann]

Actually - I think it makes sense to separate the checks for issuance and verification. As for verification a check on the issuanceDate may be useful.

[lleifermann]

I also highly recommend adding github actions to this repo. I ran all the tests locally but that seems like such a thing of the past 😄

[dmitrizagidulin]

I also highly recommend adding github actions to this repo. I ran all the tests locally but that seems like such a thing of the past smile

Yeah, not sure why there weren't on -- enabled now.

[lleifermann]

@dmitrizagidulin Any update on this?

[dmitrizagidulin]

@lleifermann - published as @digitalcredentials/vc v5.0.0