search

digitalcredentials / web-verifier-plus

VerifierPlus allows users to verify any supported digital academic credential
https://verifierplus.org
MIT License
6 stars 7 forks source link

achievement.image.id image size (should be same size as issuer.image) #89

Closed bmuramatsu closed 10 months ago

bmuramatsu commented 11 months ago

I recommend that the achievement.image.idimage be both legible and the same dimensions on screen as the issuer.image image as in LCW.

Verified works the same in VerifierPlus on Mac Safari and Android Chrome; and on iOS and Android LCW v2.0.11-Build 66

Display on VerifierPlus

Display in LCW

Tested with: https://lcw.app/request.html?issuer=https%3A%2F%2Fissuer.example.com&vc_request_url=https://verify.dcconsortium.org/request/credential&challenge=ke12345678-0001&auth_type=bearer

(Need to use the hyperlink version to add to Android LCW to test, same as dccrequest://request?issuer=https%3A%2F%2Fissuer.example.com&vc_request_url=https://verify.dcconsortium.org/request/credential&challenge=ke12345678-0001&auth_type=bearer)

bmuramatsu commented 11 months ago

Note: the achievement.image.id image is the same size on "wide" windows width in desktop browsers. As the media port (window width) decreases, the image scales smaller to the size seen in the iOS screenshot in the original issue description.

lautom36 commented 11 months ago

Fixed in this PR.

kayaelle commented 10 months ago

Looks good. Closing.