digitalcredentials / web-verifier-plus

VerifierPlus allows users to verify any supported digital academic credential
https://verifierplus.org
MIT License
6 stars 7 forks source link

Tl/crash #92

Closed lautom36 closed 11 months ago

lautom36 commented 11 months ago

This pr addresses issues https://github.com/digitalcredentials/web-verifier-plus/issues/52 and https://github.com/digitalcredentials/web-verifier-plus/issues/45.

issue https://github.com/digitalcredentials/web-verifier-plus/issues/52 is addressed by switching from the hard coded registry values to the issuer-registry-client library.

issue https://github.com/digitalcredentials/web-verifier-plus/issues/45 is addressed by adding a check to see if a proof field is in the credential. This fix is implemented in a way that makes it easy to send a different message for each missing piece of a credential in the future.

Note: A big part of these fixes is sending a error back to the display page. This is done with a mostly static error object that contains some hard coded data that in theory should be changed.

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-verifier-plus ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 17, 2023 9:49pm