Add sever select to Ethereum status page

digitaldonkey / ethereum

Drupal Ethereum module

https://www.drupal.org/project/ethereum

23 stars 14 forks source link

Add sever select to Ethereum status page #17

Open digitaldonkey opened 6 years ago

digitaldonkey commented 6 years ago

The Server status page at admin/reports/ethereum currently works only for the default server.

With the refactored Server settings there should be a SELECT field on top, where you can switch the status page to any ACTIVE server. Ideally we can reach every server config with admin/reports/ethereum/<id>

For reference. The Servers are Drupal config Entities now. With the following properties.

https://github.com/digitaldonkey/ethereum/blob/1a77d2644a84c7587ecca54596d252a624e9dec3/config/optional/ethereum.ethereum_server.infura_ropsten.yml#L1-L6

digitaldonkey commented 6 years ago

Updated in https://github.com/digitaldonkey/ethereum/commit/70ff1a19968d7b05df7dd18a1f6658408561a1a6#diff-28ce30da17769de7dd390cff37d71c70

The screen now different. A server selector would still be interesting.

foxtrotcharlie commented 6 years ago

I'd be keen to help on this, if it's still relevant? So is the idea to have something like this, possibly without the submit button so that it automatically submits when changed:

...where you can switch the status page to any ACTIVE server.

By 'active' do you mean servers that are enabled (is_enabled: true)?

amateescu commented 6 years ago

@foxtrotcharlie that looks great! I think that screenshot is exactly what @digitaldonkey wanted to have on this page.

By 'active' do you mean servers that are enabled (is_enabled: true)?

Yup :)

digitaldonkey commented 6 years ago

Great. Do you use a Drupal rendered Select? It looks a little unstyled.

Default value should be the current default server and all active servers should be selectable. We could also parameterize the page like reports/ethereum/machine_name

Would be happy for a PR.

foxtrotcharlie commented 6 years ago

Thanks for the feedback @digitaldonkey & @amateescu! Yes, it is a Drupal rendered select. Working on parameterising the page. Will submit PR once done.

foxtrotcharlie commented 6 years ago

Would one of you mind having a look here please: https://github.com/digitaldonkey/ethereum/pull/35 ?

I have some questions. Thanks!

jeffanthony commented 5 years ago

Should networks or perhaps even nodes become an Entity in itself to extend their usefulness overall?

digitaldonkey commented 5 years ago

Should networks or perhaps even nodes become an Entity in itself to extend their usefulness overall?

They both are config entities. Just without a UI implemented. You are welcome to add it.

Can you elaborate on how it would improve the usefulness from your perspective?