search

digitalearthpacific / dep-coastlines

GNU General Public License v3.0
3 stars 1 forks source link

Estuaries #31

Open jessjaco opened 6 months ago

jessjaco commented 6 months ago

Can't think of a workable workflow for sealing off estuaries. Appears DEAfrica did it by hand (see https://github.com/digitalearthafrica/deafrica-coastlines/blob/169e166befc76a2d4fd63cbb43ced01d7416a080/coastlines/vector.py#L474C17-L474C20). If we did it that way what I would do is have someone (probably me) go around and just put a splitting line where the ocean ends and the estuary starts, rasterize those lines and burn them into the candidate water rasters as land during "find_inland_water". Would need to use morphological closing or integrate the same lines with the ocean raster. Then the cutoff areas should be removed during this process.

Alternatively, it would be great if the ESA CCI water layer was good enough, both in terms of resolution and coverage to correctly ID internal water, but it doesn't appear to be. I've tried it in several ways.

I don't find the outline of these areas visually distracting, but it would bias the line length calculations.

jessjaco commented 6 months ago

An example (version 0.6.0.84) image

jessjaco commented 2 months ago

Robbi made an important comment yesterday that tide models don't work inland