search

digitalearthpacific / dep-tools

Processing tools for Digital Earth Pacific
MIT License
1 stars 0 forks source link

Replace field as default value with empty dict #39

Closed alexgleith closed 8 months ago

alexgleith commented 8 months ago

Found an issue when using the LocalDsWriter where initialising it fails due to the below error.

I don't really know how field is supposed to be used, but it doesn't work how we are using it. Happy to fix this PR with a more appropriate fix if there is a better way to do this!

---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
Cell In[14], [line 18](vscode-notebook-cell:?execution_count=14&line=18)
     [10](vscode-notebook-cell:?execution_count=14&line=10) # Set up a writer and write out the files
     [11](vscode-notebook-cell:?execution_count=14&line=11) writer = LocalDsWriter(
     [12](vscode-notebook-cell:?execution_count=14&line=12)     itempath=dep_path,
     [13](vscode-notebook-cell:?execution_count=14&line=13)     output_nodata=0,
   (...)
     [16](vscode-notebook-cell:?execution_count=14&line=16)     convert_to_int16=False
     [17](vscode-notebook-cell:?execution_count=14&line=17) )
---> [18](vscode-notebook-cell:?execution_count=14&line=18) out_files = writer.write(loaded, item_id)

File [~/.local/lib/python3.10/site-packages/dep_tools/writers.py:88](https://vscode-remote+ssh-002dremote-002bcoastlines.vscode-resource.vscode-cdn.net/home/ubuntu/dep-geomad/~/.local/lib/python3.10/site-packages/dep_tools/writers.py:88), in DsWriter.write(self, xr, item_id)
     [87](https://vscode-remote+ssh-002dremote-002bcoastlines.vscode-resource.vscode-cdn.net/home/ubuntu/dep-geomad/~/.local/lib/python3.10/site-packages/dep_tools/writers.py:87) def write(self, xr: Dataset, item_id: str) -> str | List:
---> [88](https://vscode-remote+ssh-002dremote-002bcoastlines.vscode-resource.vscode-cdn.net/home/ubuntu/dep-geomad/~/.local/lib/python3.10/site-packages/dep_tools/writers.py:88)     xr = super().prep(xr)
     [89](https://vscode-remote+ssh-002dremote-002bcoastlines.vscode-resource.vscode-cdn.net/home/ubuntu/dep-geomad/~/.local/lib/python3.10/site-packages/dep_tools/writers.py:89)     paths = []
     [90](https://vscode-remote+ssh-002dremote-002bcoastlines.vscode-resource.vscode-cdn.net/home/ubuntu/dep-geomad/~/.local/lib/python3.10/site-packages/dep_tools/writers.py:90)     assets = {}

File [~/.local/lib/python3.10/site-packages/dep_tools/writers.py:45](https://vscode-remote+ssh-002dremote-002bcoastlines.vscode-resource.vscode-cdn.net/home/ubuntu/dep-geomad/~/.local/lib/python3.10/site-packages/dep_tools/writers.py:45), in XrWriterMixin.prep(self, xr)
     [44](https://vscode-remote+ssh-002dremote-002bcoastlines.vscode-resource.vscode-cdn.net/home/ubuntu/dep-geomad/~/.local/lib/python3.10/site-packages/dep_tools/writers.py:44) def prep(self, xr: Union[DataArray, Dataset]):
---> [45](https://vscode-remote+ssh-002dremote-002bcoastlines.vscode-resource.vscode-cdn.net/home/ubuntu/dep-geomad/~/.local/lib/python3.10/site-packages/dep_tools/writers.py:45)     xr.attrs.update(self.extra_attrs)
     [46](https://vscode-remote+ssh-002dremote-002bcoastlines.vscode-resource.vscode-cdn.net/home/ubuntu/dep-geomad/~/.local/lib/python3.10/site-packages/dep_tools/writers.py:46)     if self.convert_to_int16:
     [47](https://vscode-remote+ssh-002dremote-002bcoastlines.vscode-resource.vscode-cdn.net/home/ubuntu/dep-geomad/~/.local/lib/python3.10/site-packages/dep_tools/writers.py:47)         xr = scale_to_int16(
     [48](https://vscode-remote+ssh-002dremote-002bcoastlines.vscode-resource.vscode-cdn.net/home/ubuntu/dep-geomad/~/.local/lib/python3.10/site-packages/dep_tools/writers.py:48)             xr,
     [49](https://vscode-remote+ssh-002dremote-002bcoastlines.vscode-resource.vscode-cdn.net/home/ubuntu/dep-geomad/~/.local/lib/python3.10/site-packages/dep_tools/writers.py:49)             output_multiplier=self.output_value_multiplier,
     [50](https://vscode-remote+ssh-002dremote-002bcoastlines.vscode-resource.vscode-cdn.net/home/ubuntu/dep-geomad/~/.local/lib/python3.10/site-packages/dep_tools/writers.py:50)             output_nodata=self.output_nodata,
     [51](https://vscode-remote+ssh-002dremote-002bcoastlines.vscode-resource.vscode-cdn.net/home/ubuntu/dep-geomad/~/.local/lib/python3.10/site-packages/dep_tools/writers.py:51)             scale_int16s=self.scale_int16s,
     [52](https://vscode-remote+ssh-002dremote-002bcoastlines.vscode-resource.vscode-cdn.net/home/ubuntu/dep-geomad/~/.local/lib/python3.10/site-packages/dep_tools/writers.py:52)         )

TypeError: 'Field' object is not iterable
jessjaco commented 8 months ago

To solve the mystery, field was a holdover from using dataclass as mutable default args are not allowed in class variables