By default, grab everything where ARTIST == ALBUM ARTIST, ignoring TYPE 2 COMPILATIONS but including TYPE 1 & TYPE 3 isCompilation releases.
"include_featured_in": true by itself did nothing; it was unchecked.
"include_unofficial": false is ignored once "include_compilations": true is enabled.
"include_compilations": true by itself grabbed TYPE 2 releases, as well as TYPE 0 & TYPE 3 FEATURED IN releases.
"include_compilations": true + "include_featured_in": true together grabbed the above as well as TYPE 1 FEATURED IN releases and TYPE 1 & TYPE 3 COMPILATIONS (isCompilation) releases.
Behavior now:
By default, grab everything where ARTIST == ALBUM ARTIST, including TYPE 2 and TYPE 1 & TYPE 3 isCompilation.
"include_unofficial": false is always adhered to.
"include_compilations": true removes the check for ARTIST == ALBUM ARTIST in compilation releases.
"include_featured_in": true removes the check for ARTIST == ALBUM ARTIST in non-compilation releases.
Notes:
Most TYPE 1 compilations are things like "TOP HITS 20XX" or "10'S ROCK" and while most of them are marked isCompilation, not all of them are.
Two config options that may be useful to implement in the future would be filtering ARTIST == ALBUM ARTIST compilations (include_self_compilations), and TYPE 2 vs isCompilation filtering (unsure how these releases are meant to differ.)
Thanks for the PR and apologies for the delay in reviewing. I will test this locally to see what additional releases are detected against my existing database.
Behavior before:
isCompilation
releases."include_featured_in": true
by itself did nothing; it was unchecked."include_unofficial": false
is ignored once"include_compilations": true
is enabled."include_compilations": true
by itself grabbed TYPE 2 releases, as well as TYPE 0 & TYPE 3 FEATURED IN releases."include_compilations": true
+"include_featured_in": true
together grabbed the above as well as TYPE 1 FEATURED IN releases and TYPE 1 & TYPE 3 COMPILATIONS (isCompilation
) releases.Behavior now:
isCompilation
."include_unofficial": false
is always adhered to."include_compilations": true
removes the check for ARTIST == ALBUM ARTIST in compilation releases."include_featured_in": true
removes the check for ARTIST == ALBUM ARTIST in non-compilation releases.Notes:
isCompilation
, not all of them are.include_self_compilations
), and TYPE 2 vsisCompilation
filtering (unsure how these releases are meant to differ.)