search

digitalec / deemon

Monitor specified artists for new releases
GNU General Public License v3.0
176 stars 15 forks source link

Check if release date has changed on existing release #70

Open sunradiofree opened 2 years ago

sunradiofree commented 2 years ago

When release date is in the future and some track have been availabled before, deemon thinks it has already download the full album. Perhaps, it has only downloaded the available tracks at moment of the download. When the release date is reach, nothing append, so it looses the other tracks.

sunradiofree commented 2 years ago

In my case the realease_id was registered in database as "2021-01-01". So I think it was not seed as "future release". Moreover, with id 334190677 it could not be released in "2021-01-01". So hard to dectect ! Maybe logging releases with "not available tracks" and re-try to download them in the future?

sunradiofree commented 2 years ago

Other id, checkin release date, and if release date is not the same than the one registered in database, re-download the album.

digitalec commented 2 years ago

I'll check into this but if the release date is not in the future, I have no other way of knowing if it's a future release.

Sometimes tracks are not available due to licensing so retrying on every refresh would cause that album to always fail.

sunradiofree commented 2 years ago

I think this album (334190677) was first set up as "20210101" (because this is the release date registered in the db file) and today change to "20220715", with enabling all the tracks. That's why I suggest checking the release date when refreshing, so if the date change, re-downloading the release. Of course I understand that retry each time not available tracks will always fail and is not a correct way.

digitalec commented 2 years ago

That may be possible. I already perform a check if the ID exists so I would expand that to if the ID and release date exist as a pair. I'm away for the next week but I'll implement this when I return. Good idea!

sunradiofree commented 2 years ago

deemon I set the right release date to the db and set future to "1". It downloads the album but it set again the release date to "2022-08-12", so it's not the same field for release date like in deemix. Detecting changes could not work because it doesn't change...

digitalec commented 2 years ago

Deezer has 3 different release dates: Original, Physical and Digital. I've experimented with the order in the past and found the current order to be the most accurate. I'll look into this particular case though to see how this could be resolved.

sunradiofree commented 2 years ago

ok, but when some tracks are not availables, they will never be downloaded with deemon.this joins the subject of failed downloads. https://www.deezer.com/album/366967207 https://www.deezer.com/album/364892387 At this moment this 2 albums have been tagged as "downloaded" in deemon but a lot of tracks were not available, and I need to manually wait the other release date and download them.Nevertheless, it's good to have as soon as possible availables tracks of a future release...