digitales / Import-Users-from-XML

Import users from XML files
2 stars 0 forks source link

init, add_admin_pages, process_xml should be static methods #1

Open dario23 opened 7 years ago

dario23 commented 7 years ago

some methods are called statically, but aren't declared as such, leaving ugly error messages on the wp page:

Deprecated: Non-static method Import_Users_From_Xml::init() should not be called statically in /var/www/wordpress/wordpress/wp-content/plugins/Import-Users-from-XML/import-users-from-xml.php on line 393

Deprecated: Non-static method Import_Users_From_Xml::process_xml() should not be called statically in /var/www/wordpress/wordpress/wp-includes/class-wp-hook.php on line 298

Deprecated: Non-static method Import_Users_From_Xml::add_admin_pages() should not be called statically in /var/www/wordpress/wordpress/wp-includes/class-wp-hook.php on line 298

declaring the three mentioned methods static seems to fix things

digitales commented 7 years ago

Hi @dario23 thanks for the issue. I believe WordPress has moved on a lot in the 6 years since this repo was last updated.

I'm happy to transfer this repo to you, or to accept a pull request.

dario23 commented 6 years ago

hi @digitales; i probably won't be taking over the repo, i don't think i'll have the time for longer involvement. i hope i'll find the time in the next days to submit a pull request for the issues i ran into, though :)