digitalfabrik / app-cross_platform

Mobile guide for refugees - app frontend
http://integreat-app.de/
13 stars 1 forks source link

Character entities are not replaced by character in pages list #443

Closed dkehne closed 5 years ago

dkehne commented 5 years ago

I have found some characters, which are not displayed correctly. I found it in Herne under "Events". photo_2019-01-14_14-42-28

svenseeberg commented 5 years ago

@maxammann @timoludwig @Schedulaar: Vince and I are thinking about solving this in the REST API by replacing the entity codes with the correct UTF-8 characters. The list view in the Xamarin app is not using HTML widgets so we need to replace the characters somewhere. Does anybody see a problem with replacing the characters?

maxammann commented 5 years ago

Which fields in the page model would be affected?

timobrembeck commented 5 years ago

excerpt, content and in special cases the title

maxammann commented 5 years ago

https://github.com/Integreat/integreat-webapp/blob/0a468743ab6148c7f1a0c28142cab14187164624/src/modules/endpoint/endpoints/events.js#L49

This is our solution in the webapp for this problem.

maxammann commented 5 years ago

Changing it should not break the webapp. But it may increase the already long API response time

svenseeberg commented 5 years ago

@Simple-codinger found a working 1-line solution (based on @maxammann's suggestion) for the Xamarin app that solves the issue. Thanks for the quick answers.

maxammann commented 5 years ago

:+1: @svenseeberg we should specify this for django

vincentgierisch commented 5 years ago

Should be fixed: https://github.com/Integreat/app-cross_platform/commit/68a004b15a99b68d2f28877585ef9dd0b5653a06