digitalfabrik / integreat-app

React JS and React Native App for Integreat
https://integreat.app
MIT License
45 stars 15 forks source link

IGAPP-1265: Icons not displayed correctly if page has children #2196

Closed jira-to-github-migrator[bot] closed 1 year ago

jira-to-github-migrator[bot] commented 1 year ago

Svenja Osmers - 24.3.2023, 11:36:55

When a page contains an icon and has children, the icon is not displayed correctly but as an empty box with black margin (only native app)

https://integreat.app/hochtaunuskreis/de/wahlen-3

We currently use two ways to render html: react-native-render-html, which translates the html to native components, and react-native-webview, which displays the html in a webview. With the webview, displaying svg icons works already and is easier for us to maintain. Therefore switch to react-native-webview for all remote content from the cms.

Acceptance criteria:

Environment: App Version 2023.3.2 and Android 12 Linked issues:

jira-to-github-migrator[bot] commented 1 year ago

steffenkleinle - 8.5.2023, 14:36:17

The mentioned site uses an svg which is not supported as cms content by us. AFAIK it should not be possible to upload svgs in the cms in the first place though. Did anything change here?

steffenkleinle - 25.5.2023, 09:42:33

<~svenja.osmers> perhaps you could manually replace the icon with a png and delete the svg for the time being? Thanks

Svenja Osmers - 3.6.2023, 13:09:55

I can but it concerns all icons that can be set via the editor form in the CMS, I believe...so as soon as a region uses icons on a page with children, we'll have this problem.

steffenkleinle - 7.6.2023, 11:20:23

Okay, nevermind, we found a fix :)