digitalfabrik / integreat-app

React JS and React Native App for Integreat
https://integreat.app
MIT License
45 stars 15 forks source link

Add "Only by appointment" to the opening hours of POIs #2457

Open LeandraH opened 9 months ago

LeandraH commented 9 months ago

Is your feature request related to a problem? Please describe. As described in https://github.com/digitalfabrik/integreat-cms/issues/2398, there are POIs that are only "open" if you have an appointment. The CMS ticket for it is almost done, we should figure out how to handle this in the app.

Describe the solution you'd like As a user of the Integreat App I want to see on which days I need an appointment to go to a POI so that I do not waste my time and have all the relevant information before going.

Describe alternatives you've considered We could ignore it, which seems like a terrible idea since it will soon be possible to add the information in the CMS.

Additional information This draft PR might be a good point to start or take code from: https://github.com/digitalfabrik/integreat-app/pull/2722

LeandraH commented 9 months ago

@hauf-toni Sorry, here is the issue I meant.

hauf-toni commented 9 months ago

Design proposal can be found 🚩 here

LeandraH commented 9 months ago

Looks good though if I understand the CMS ticket correctly, the "open by appointment"-label applies to specific days and not everything. Sorry, I didn't realize that until now. But I guess we can simply move the text "Termin erforderlich, [...]" to under the days where you need an appointment?

hauf-toni commented 9 months ago

Looks good though if I understand the CMS ticket correctly, the "open by appointment"-label applies to specific days and not everything. Sorry, I didn't realize that until now. But I guess we can simply move the text "Termin erforderlich, [...]" to under the days where you need an appointment?

An alternative design proposal can be found on figma as well

LeandraH commented 8 months ago

Looks good to me, I think we can start working with that :)

ztefanie commented 8 months ago

Blocked by

timobrembeck commented 8 months ago

The corresponding CMS issue is now fixed, the opening hours contain an additional boolean field appointmentOnly now.