search

digitalfabrik / integreat-app

React JS and React Native App for Integreat
https://integreat.app
MIT License
45 stars 15 forks source link

Merge internal and external news (TüNews, Amal, local push news) #2537

Open dkehne opened 8 months ago

dkehne commented 8 months ago

As a user I want to have an overview of all news in one screen instead of clicking different news provider buttons. Due to the current planning of embeding Amal News as an additional content provider, we should work out a design which can handle n news providers.

Acceptance Criteria:

Addtional information:

CMS issue: https://github.com/digitalfabrik/integreat-cms/issues/2833

sarahsporck commented 5 months ago

Do we need filterbars? Is adding Amal News already discussed? So many questions @dkehne

dkehne commented 5 months ago

No Filterbar yet. A user just wants news, not filtering sources.

Of course we should mark from which source the data comes, maybe in the same way we plan that with the external job and course data.

We decided to make a pilot and add Amal news in Maintal. It can be either instead of tünews or already together with it.

sarahsporck commented 5 months ago

Is there a due date for this pilot project?

dkehne commented 5 months ago

@sarahsporck - we have now received the API (same format as TüNews).

https://amalberlin.de/de/wp-json/wp/v2/posts https://amalberlin.de/ua/wp-json/wp/v2/posts https://amalberlin.de/fa/wp-json/wp/v2/posts https://amalberlin.de/ar/wp-json/wp/v2/posts

I am not sure yet on which category id we should filter, but i will receive the info soon.

Coming back to your question: there is no due date offically. Completing the task in the first half of 2024 would be great, depending also on the ui-ux speed/capacities.

steffenkleinle commented 5 months ago

@sarahsporck - we have now received the API (same format as TüNews).

https://amalberlin.de/de/wp-json/wp/v2/posts https://amalberlin.de/ua/wp-json/wp/v2/posts https://amalberlin.de/fa/wp-json/wp/v2/posts https://amalberlin.de/ar/wp-json/wp/v2/posts

I am not sure yet on which category id we should filter, but i will receive the info soon.

Coming back to your question: there is no due date offically. Completing the task in the first half of 2024 would be great, depending also on the ui-ux speed/capacities.

Two questions: Does it support pagination, i.e. just loading a specific amount of posts a time? Also, is there an endpoint for getting a single post by id?

ztefanie commented 5 months ago

It is a standard wordpress api, pagination and getting single posts is possible (just tested), check the docs here: https://developer.wordpress.org/rest-api/reference/posts/#arguments

dkehne commented 5 months ago

The category taxonomy id for the non-regional news (we only should display) is 10884

dkehne commented 2 months ago

Is there any progress here or could someone from the team takeover?

steffenkleinle commented 2 months ago

No progress yet. We can easily implement amal news as an additional news tab/the only news source.

If we actually want to do it in one list we need a wrapper in the CMS scraping all the APIs (internal news, tünews, amal, ...) and returning everything from one endpoint (with pagination and so on). That would be the best (i.e. cleanest) solution anyway and which is what we decided in the tech team what we want.

So we can do it quick in the frontend in another tab or we do it properly and handle that in the CMS. What do you prefer @dkehne? Then again its a question of prioritizing. Also we still need a design for displaying it in the same list.

dkehne commented 1 month ago

@steffenkleinle it is not that urgent, because we plan to start the Amal-News-Embedding from January 2025. So i would prefer to have one view (not the tabbing) where the entries are marked somehow so that the user can see what the source is (local integreat team, or external from TüNews/Amal or others). Could you hand it over to UI/UX to have a design? Do we need to have another issue for CMS or can we just handover that issue here somehow?

steffenkleinle commented 1 month ago

@steffenkleinle it is not that urgent, because we plan to start the Amal-News-Embedding from January 2025.

Should work.

So i would prefer to have one view (not the tabbing) where the entries are marked somehow so that the user can see what the source is (local integreat team, or external from TüNews/Amal or others). Could you hand it over to UI/UX to have a design?

Can you perhaps just add that information and maybe explain the purpose of the issue a little bit more in the issue description above ( :arrow_up: )? Thanks. Let me know if you are done or move the issue to UI/UX nextup yourself afterwards :)

Do we need to have another issue for CMS or can we just handover that issue here somehow?

Yes, I think we need a separate CMS issue. I think we should get all news via one endpoint. Does this include tünews? I can create an issue. I think it is quite hacky to combine multiple sources in one view in the frontend. CMS issue: https://github.com/digitalfabrik/integreat-cms/issues/2833