search

digitalfabrik / integreat-app

React JS and React Native App for Integreat
https://integreat.app
MIT License
46 stars 14 forks source link

Old icon for Behörde/Amt still shown on map #2940

Open osmers opened 3 weeks ago

osmers commented 3 weeks ago

Describe the Bug

The old icon for Behörde/Amt is still shown on the map.

Steps to Reproduce

  1. Go to https://integreat.app/augsburg/de/locations?category=1
  2. Zoom in
  3. See that the icon on the map is still the hammer

Expected Behavior

Icon shown on the map should be the building

Actual Behavior

Icon shown on the map is still the hammer

Additional Information

Old issue: https://github.com/digitalfabrik/integreat-app/issues/2657 Design: https://www.figma.com/design/cA4F2MwHs2LNGviOWUjfE9/Integreat-Tickets-Frontend?node-id=1136-3404&node-type=frame&t=OfgTae7shTAdSJdk-0 CMS issue: https://github.com/digitalfabrik/integreat-cms/issues/2800

Icon should be what's seen in the top left, but is what's actually on the map.

image

f1sh1918 commented 3 weeks ago

Short explanation For icons on the map we use a separate repository that creates an IconSprite for performance reasons https://github.com/digitalfabrik/integreat-maplibre-style You can find there a general manual. In this case you have to replace the old hammer svg icon for each color group by the new one that you probably get from cms or design team. Please ensure that the naming is still correct: f.e. health_#3700D2.svg

ztefanie commented 3 weeks ago

ok we are having dissens if this is a good first issue :D

steffenkleinle commented 3 weeks ago

ok we are having dissens if this is a good first issue :D

Seems like it haha. But since @f1sh1918 wrote the following on mattermost, I guessed it would not be that easy or rather a good first issue, but I don't mind at all:

Since this is not very handy to do i suggested to not change single icons but in a batch