digitalfabrik / integreat-app

React JS and React Native App for Integreat
https://integreat.app
MIT License
48 stars 16 forks source link

Open external links in new tab #2990

Open ztefanie opened 3 weeks ago

ztefanie commented 3 weeks ago

Is your feature request related to a problem? Please describe. As a user i want to easily go back to integreat after opening a external link

Describe the solution you'd like External links should be opened in a new link

Describe alternatives you've considered Keep it as it is

Additional context

bahaaTuffaha commented 3 weeks ago

Thinking out loud: For any Link from react-router-dom or tag just add target='_blank'

steffenkleinle commented 3 weeks ago

@ztefanie we had the same discussion a few years back, see https://chat.tuerantuer.org/digitalfabrik/pl/rj7ars9mmfbg8na47eyz78z5be. In the end, we decided to keep opening external links in the same tab. Perhaps we should check if we actually think that we should change this now. Personally I agree that it probably makes sense though.

ztefanie commented 3 weeks ago

yeah i remembered this too, but as both of our designers agreed with the target group feedback that this would be an improvement, i think we have enough input / expertise to do it.

LeandraH commented 1 week ago

Thinking out loud: For any Link from react-router-dom or tag just add target='_blank'

@bahaaTuffaha Yup, perfect, do you want to take on this one? You'll have to figure out how to get the target into the RemoteContent :)

bahaaTuffaha commented 1 week ago

RemoteContent? 🤔 we either adjust the content (my guess is from cms)😇 or inject some JavaScript to webview 😈

LeandraH commented 1 week ago

The file is called RemoteContent :) We could ask the CMS team to adjust this but I think it's more of an App behavior.