digitalfabrik / integreat-cms

Simplified content management back end for the Integreat App - a multilingual information platform for newcomers
https://digitalfabrik.github.io/integreat-cms/
Apache License 2.0
55 stars 33 forks source link

Sometimes translation status incorrect after XLIFF import #1871

Open timobrembeck opened 1 year ago

timobrembeck commented 1 year ago

Describe the Bug

In the production system, we had the case that most of the translations were imported as draft, even though the source translations were public. In theory, the import should inherit the status from the source translation if the target translation does not yet exist, so we have to figure out why this didn't work in this case.

Steps to Reproduce

I wasn't able to reproduce this problem locally yet

Expected Behavior

If a target translation does not yet exist, it should inherit the status from it source translation.

Actual Behavior

In some cases, this did not work

Additional Information

This could be related to recent changes to the translation state: #1613, #1624 or #1691 This might also be an infra ticket, though I have no idea how database inconsistencies could cause this problem.

Screenshot 2022-11-17 at 12-42-35 Integreat Redaktionssystem

MizukiTemma commented 1 year ago

Is German the direct source language of Russian in the reported case in the foto? If not (Russian has another language X as source language and X has German as cource language), one possible scenario was found.

Reproducing is possible for example with Arabic as target language, while Arabic has English as source language and English has German as source language.

  1. Create a new page in German and publish this.
  2. Create a xliff file for arabic translation.
  3. Import this xliff.
  4. The status of the arabic translation is draft, whereas the german translation is public.

Users cannot export xliff file for arabic translation when there is no english (direct source language) translation yet. Though users can of course create an xliff file by themselves (for exmaple, by modifing page number and language code in a xliff file, which was originally exported for another language or another language).

timobrembeck commented 1 year ago

Is German the direct source language of Russian in the reported case in the photo?

Yes, the region only has one source language (German) and all other languages directly depend on it. Thanks a lot for digging into this issue, but unfortunately there seems to be a different problem...

MizukiTemma commented 1 year ago

Thank you for quick reply 😃 Then I can look for another possible case 👍

osmers commented 1 year ago

@timoludwig is there still a question attached to this issue?

osmers commented 10 months ago

@timobrembeck do you need any more info for this issue?

timobrembeck commented 10 months ago

@osmers Yes, but we don't know what information that is. We were unable to reproduce the issue, so we don't know what we're supposed to do here. If this happened/happens again, please let us know as much about it as possible.

osmers commented 10 months ago

@timobrembeck I asked the team and apparently there is no consistency or regularity to it, it just happens randomly. So I put the issue into the backlog and if we find some rule as to when and why it happens, we'll put it in here.

timobrembeck commented 10 months ago

Thanks, it would also be helpful if you just tell us when it happened, then we can examine the logs etc. to get additional information by ourselves.