digitalfabrik / integreat-cms

Simplified content management back end for the Integreat App - a multilingual information platform for newcomers
https://digitalfabrik.github.io/integreat-cms/
Apache License 2.0
56 stars 35 forks source link

Replace pylint + isort by ruff #2442

Open timobrembeck opened 1 year ago

timobrembeck commented 1 year ago

Motivation

Our CI workflows take quite a while, mostly due to the tests, but also pylint is taking a considerable amount of time. I think we could reduce this by migrating from pylint to ruff:

232603514-c95e9b0f-6b31-43de-9a80-9e844173fd6a

Proposed Solution

Alternatives

Maybe it isn't worth the effort...

Additional Context

Pylint is not completely implemented by ruff yet (see https://github.com/astral-sh/ruff/issues/970), so we would loose a few rules (but also ruff has a lot of extra checks that pylint doesn't, mostly those of flake8)...

JoeyStk commented 6 months ago

Not yet fully resolved. The following steps are still needed:

deen13 commented 6 months ago

To fully address this ticket, we also need to remove the pylint leftovers. I've already dropped isort support in #2758, as it is now covered by Ruff.