digitalfabrik / integreat-cms

Simplified content management back end for the Integreat App - a multilingual information platform for newcomers
https://digitalfabrik.github.io/integreat-cms/
Apache License 2.0
56 stars 35 forks source link

[2024-11-07] Remove E-mail, phone number and website from POI #3086

Open MizukiTemma opened 1 month ago

MizukiTemma commented 1 month ago

Motivation

Currently POI has three fields for contact information: E-mail, phone number and website. We came to an idea, however, while discussing and implementing contact management system, that those fields/information must be managed in contacts in futur.

Proposed Solution

Alternatives

User Story

Additional Context

Design Requirements

MizukiTemma commented 1 day ago

As "primary contact" meant is contact objects without "point_of_contact_for". There is a constraint that for each POI max. one primary contact exists (already implemented).

For this issue I have imagined following work steps:

  1. For each POI which has at least one of E-mail, phone number and website, create a contact object with them ("point_of_contact_for" and "name" stay empty).
  2. Remove E-mail, phone number and website fields from POI model.
  3. Remove the box of those three fields from the POI form.
  4. Adjust API so it finds the primary contact of the requested POI and reads those fields from the primary contact.
osmers commented 13 hours ago

Just one question before this gets closed - didn't we say that this cannot be removed before we have not migrated the information stored there to a general contact?

david-venhoff commented 11 hours ago

Yes, this will be part of this issue:

  • Create a migration to create contacts from those poi fields and remove the fields from poi

Though it looks like it is currently missing from the pr