digitalfabrik / lunes-app

The front end for the Lunes vocabulary trainer. Back end: https://github.com/digitalfabrik/lunes-cms
https://lunes.app
Apache License 2.0
24 stars 5 forks source link

983: Upgrade dependencies #1013

Closed steffenkleinle closed 5 months ago

steffenkleinle commented 6 months ago

Short description

Upgrade most dependencies.

Proposed changes

Separate PR for an upgrade of prettier: #1014.

Created separate tickets for upgrading

Tickets already existing for upgrades/migrations:

Ticket for unmaintained dependencies: https://github.com/digitalfabrik/lunes-app/issues/1015.

Side effects

Hopefully none.

Resolved issues

Fixes: #983.


ztefanie commented 6 months ago

Does not work for me on mac,

Screenshot 2024-04-08 at 09 58 11

I deleted the pods folder, cleared the pod cache and reinstalled everything.

ztefanie commented 6 months ago

Could be due to outdated OS (and therefore xcode version) of my mac.

steffenkleinle commented 5 months ago

@ztefanie @LeandraH should I wait with merging until you have a new mac and can test this?

ztefanie commented 5 months ago

@ztefanie @LeandraH should I wait with merging until you have a new mac and can test this?

Maybe @f1sh1918 can test it?

f1sh1918 commented 5 months ago

leandras approve should be sufficient? @steffenkleinle

LeandraH commented 5 months ago

Since I now wrote part of the code, I feel like another person should test the part that I wrote. But that might be paranoia on my part :)

steffenkleinle commented 5 months ago

I am fine with both, will be tested by Martin before a production release again anyway right? Also @LeandraH I think you just made sure that dependencies are correctly picked up for iOS, you didn't change any user-visible code. So I think we could merge this from my perspective.

LeandraH commented 5 months ago

Works for me