digitalfabrik / lunes-app

The front end for the Lunes vocabulary trainer. Back end: https://github.com/digitalfabrik/lunes-cms
https://lunes.app
Apache License 2.0
23 stars 5 forks source link

LUN-439: Replace react-native-camera #873

Open jira-to-github-migrator[bot] opened 11 months ago

jira-to-github-migrator[bot] commented 11 months ago

Stefanie Metzger - 26.9.2022, 11:58:44

react-native-camera is now deprecated. Since we use https://github.com/ivpusic/react-native-image-crop-picker for selecting image from gallery it would make sense to use it also for camera

 

Maybe we should update as well, not really urgent. 

Also remove the patch for it.

 

Maybe this would be the best chioce: https://github.com/mrousavy/react-native-vision-camera

 

Also see comments

 

Note for testing: Nothing should change in camera behaviour.

Environment: - Linked issues:

jira-to-github-migrator[bot] commented 11 months ago

lunars97 - 24.4.2023, 11:00:40

<~stefanie.metzger> seems like react-native-image-crop-picker does not have built-in bar-code scanner feature

lunars97 - 24.4.2023, 13:07:21

Maybe we can replace entirely with https://github.com/mrousavy/react-native-vision-camera

Stefanie Metzger - 25.4.2023, 13:15:43

Seems a good choice to me, I think we need to use two libraries if we want to pick from gallery and read QR-Codes, as I think there is no good library supporting both. Let's discuss this in the grooming, as I see a high risk the PR is rejected, because there are other ideas which library would be the best fit.

lunars97 - 25.4.2023, 14:20:19

if we want to implement react-native-image crop-picker then we can also consider https://www.npmjs.com/package/react-native-qrcode-scanner  so that we can combine these two

sarahsporck commented 10 months ago

react-native-qrcode-scanner also hasn't been updated for 2 years. I'd tend to use react-native-vision-camera. Especially as the new version seems to be very performant and react-native 0.72 conform. The only argument against it is that the implemented barcode scanners all rely on googles mlkit, and are therefore not really open source. @SteffiStuffel would that be a problem? We could also try to spend some time to implement barcode scanning with zxing.

ztefanie commented 10 months ago

@sarahsporck Fine for me.

ztefanie commented 9 months ago

Decision from grooming: We wait for react-native-vision-camera to become stable in the current version.