LUN-463: The AudioRecordOverlay triggers onAudioRecorded too early

[jira-to-github-migrator[bot]]

Saliu Bah - 1.12.2022, 16:00:14

The AudioRecordOverlay triggers on onAudioRecorded in the {{{}onStartRecordin{}}}g. This is misleading as the term audioRecorded implies that the audio was already recorded and is not still {}recording{}.

I suggest triggering the event in the onStopRecording function. I already did that on my branch, the solution can be seen here: https://github.com/digitalfabrik/lunes-app/commit/81fd7e4bb50087823a8284b2ec9a7579860e9098

Environment: - Linked issues:

[jira-to-github-migrator[bot]]

Stefanie Metzger - 21.2.2023, 08:54:36

<_{andreas.fischer> I think the current solution is better than the one suggested in this ticket. What do you think? I would reject this, if you are fine with this. <}sarah.sporck> <~leandra.hahn> 

LeandraH - 21.2.2023, 11:29:22

Fine by me :)

f1sh1918 - 22.2.2023, 15:55:51

<~stefanie.metzger> hm salua is kind of right that we should trigger the "onAudioRecorded" in the "onStopRecording" fkt but his solution can be simplified. Gonna create a pr