search

digitalfabrik / lunes-app

The front end for the Lunes vocabulary trainer. Back end: https://github.com/digitalfabrik/lunes-cms
https://lunes.app
Apache License 2.0
24 stars 5 forks source link

LUN-464: ExerciseScreen shows exercises as unlocked which shouldn't be unlocked #893

Closed jira-to-github-migrator[bot] closed 1 year ago

jira-to-github-migrator[bot] commented 1 year ago

Saliu Bah - 1.12.2022, 17:39:55

The ExerciseScreen shows Exercises as unlocked which have any saved progress at all. It should  only show exercises where the score saved in progress is above the SCORE_THRESHOLD_UNLOCK .

Also, the naming chosen in the code wasn't very easily understandable for me personally.

A possible solution for this problem can be seen in this commit on my fork of the project: https://github.com/bob606/lunes-app-BA/commit/4d155cdd1f8972d3c986a11583c53e24d303ae2e

![](!! This is a potentially breaking change, as previously unlocked modules (which should have been unlocked in the first place) are now locked again !!)

Environment: - Linked issues:

jira-to-github-migrator[bot] commented 1 year ago

Stefanie Metzger - 5.12.2022, 09:32:29

Cannot reproduce. <~saliu.bah> Can you share a screenshot and some data from async storage where this error happens. Vocabulary List and Choose-Word-Exercise are always unlocked, this is intended.

Saliu Bah - 5.12.2022, 11:15:20

Did you try to hit zero right words in level 1, in not yet worked on module? You will see that level 2 will still unlock