digitalfabrik / lunes-app

The front end for the Lunes vocabulary trainer. Back end: https://github.com/digitalfabrik/lunes-cms
https://lunes.app
Apache License 2.0
24 stars 5 forks source link

905: Adjust write exercise for repetition exercise #998

Closed ztefanie closed 1 year ago

ztefanie commented 1 year ago

Short description

Proposed changes

Side effects

Could break any existing logic of the writing exercise. Should be tested.

Resolved issues

Fixes: #905

ztefanie commented 1 year ago

Tested in emulated iOS, looks great, thank you! A few small issues:

I seem to have a small issue that doesn't happen with all words where

  1. the word is ready to be trained again and in Lernstufe 1
  2. I tap on "Jetzt wiederholen"
  3. without doing the exercise, I tap to end the exercise and confirm that
  4. and the word is downgraded to the not-learned bucket. I would expect the word in that case to not move?

I checked this and cannot reproduce. If you do : 1) Start the exercise 2) close the exercise The progress stays the same, nothing is changed, every word is in the same bucket

If you do) 1) Start the exercise 2) Click "Show solution" 3) Close the exercise The first word you did "wrong" (=you looked up the solution) is moved to a lower bucket. This is expected behaviour.

Can you please share some more information?

Also, the Solve All cheat in the repetition exercise seems to only solve the current VocabularyItem and then close the exercise. When I have three words to repeat and tap on solve all at the first word, the exercise closes and I still have two words to repeat.

Good catch, fixed it.

I have also had at least one moment where I had one word to repeat, I did that (manually), and the RepetitionScreen showed that I had no words left to repeat but the footer showed one word to repeat.

Yes updating of the footer does not yet work correctly, it is part of #906