digitalfondue / jscoverproxy-maven-plugin

a maven plugin for JSCover for a simple use case: generate coverage in conjunction of the jasmine-maven-plugin
Apache License 2.0
1 stars 1 forks source link

Upgrade to JSCover 2.x #7

Closed BBE78 closed 7 years ago

BBE78 commented 7 years ago

JSCover has released 2.0.1 version few days ago: upgrade the plugin to use this new major version

syjer commented 7 years ago

Hi @BBE78 , thank you for the head up, I'll do the update as soon as possible (Ideally this afternoon)

tntim96 commented 7 years ago

It may not be a trivial upgrade to due to different guava dependencies. See how you go.

syjer commented 7 years ago

@tntim96 yep, you are right, the guava dependency seems to cause some classloader issue (missing classes).

I'll dig deeper if I can find a decent solution.

syjer commented 7 years ago

version 2.0.1 is up on maven central: http://central.maven.org/maven2/ch/digitalfondue/jscover/jscoverproxy-maven-plugin/2.0.1/ . I've tested on my test application (https://github.com/syjer/spring-ng-webjar) and it seems to work :)