search

digitalfondue / lavagna

Lavagna: issue tracker/project management tool
http://lavagna.io
GNU General Public License v3.0
636 stars 110 forks source link

smtp-configuration form validation added. #23

Closed velmuruganvelayutham closed 8 years ago

velmuruganvelayutham commented 8 years ago

Added form validation while saving SMTP configuration parameters.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 75.671% when pulling b5d7a9d1a69c4bb607a3001d77b4b9c5d0eb0318 on velmuruganvelayutham:smtp-config-form into 05e3b3f1f8073b83b8b9212718ab751d5b396b2c on digitalfondue:1.0.x.

syjer commented 8 years ago

@velmuruganvelayutham thanks for the PR :), tomorrow I'll have a look

syjer commented 8 years ago

@velmuruganvelayutham , could you move the hardcoded text (see the comment in the review) in messages_en.properties files?

You should put the keys near "partials.admin.manage-smtp-configuration.host" :).

After you have updated the PR, I'll merge it :)

Thank you.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 75.671% when pulling c8e8ae725226badcc84519999109bc758fab8dd1 on velmuruganvelayutham:smtp-config-form into 05e3b3f1f8073b83b8b9212718ab751d5b396b2c on digitalfondue:1.0.x.

velmuruganvelayutham commented 8 years ago

@syjer I agree with all your review comments !. Done the changes and pushed it..

syjer commented 8 years ago

@velmuruganvelayutham thank you :)