digitalfondue / lavagna

Lavagna: issue tracker/project management tool
http://lavagna.io
GNU General Public License v3.0
636 stars 110 forks source link

i18n for src/main/webapp/app-login/app-login.js #37

Closed ghaseminya closed 7 years ago

ghaseminya commented 7 years ago

Hi Why src/main/webapp/app-login/app-login.js couldn't accept i18n ? I add some new properties to message_en.properties for this page but when use theme in app-login.js file does not work? example hosted here: http://ketabfish.ir

syjer commented 7 years ago

Hi @mmghasemi , you are right. It's an oversight on our side. We will fix it.

syjer commented 7 years ago

Hi @mmghasemi , I've pushed a first test for supporting i18n in the login page.

ghaseminya commented 7 years ago

Thanks @syjer for fast coding... I pull and test.

ghaseminya commented 7 years ago

I thought some utf-8 encoding had some error in app-login.js نام کارب http://iproman.ir

syjer commented 7 years ago

Hi @mmghasemi , as you may have noticed, the property files in java are not utf-8 by default, you may use an IDE (intellij for example) which convert the characters in the appropriate forms or use the native2ascii command (http://docs.oracle.com/javase/7/docs/technotes/tools/windows/native2ascii.html) which is bundled by default with the jdk to convert the file.

ghaseminya commented 7 years ago

Hi @syjer I used native2ascii command for change properties for support UTF-8, but in all page unicode characters is properly ok but in login page fail you can login to page to see correct Unicode in dashboard and other pages http://iproman.ir username=mnm

syjer commented 7 years ago

thanks for the feedback, I'll have a look.

ghaseminya commented 7 years ago

thanks

syjer commented 7 years ago

Ok, I'm able to reproduce the error, I'll commit a fix as soon as possible

syjer commented 7 years ago

@mmghasemi , I've pushed the fix :). Could you try to check if it work correctly ?

ghaseminya commented 7 years ago

thanks, Yes...i pull and check it again...

ghaseminya commented 7 years ago

Its OK.