search

digitallyinduced / ihp

🔥 The fastest way to build type safe web apps. IHP is a new batteries-included web framework optimized for longterm productivity and programmer happiness
https://ihp.digitallyinduced.com/
MIT License
4.91k stars 195 forks source link

Update testing.markdown - workaround GH Runner disk space issue #1997

Closed AronNovak closed 2 months ago

amitaibu commented 2 months ago

Thanks. I suggest we link to https://github.com/digitallyinduced/ihp-boilerplate/blob/master/.github/workflows/test.yml so we won't have to maintain the same code in two places.

amitaibu commented 2 months ago

@mpscholten seems like tests are failing. Do you happen to know know why?

mpscholten commented 2 months ago

I've moved the hsx tests to the ihp-hsx package (previously the were part of the ihp package), but forgot to remove them from the Test/Main.hs. Will fix this in a minute :+1:

mpscholten commented 2 months ago

Fixed via https://github.com/digitallyinduced/ihp/commit/56300596ac8522759db953407ab99696f97b28e6

amitaibu commented 2 months ago

Thanks

amitaibu commented 2 months ago

I still have one concern: before you fixed it, the test on master occasionally worked.

image

Maybe tests are not running as they should on master?

mpscholten commented 2 months ago

Good point. I've changed the github configuration via https://github.com/digitallyinduced/ihp/commit/6bba47921a27b61e1098cc01106f17fe01a3a4ad this likely fixes that 👍