search

digitallyserviced / semanticolor

Provide Atom editor with semantic color highlighting.
https://atom.io/packages/semanticolor
MIT License
34 stars 3 forks source link

ES6 template literals - interpolation colouring #12

Closed davidsharp closed 8 years ago

davidsharp commented 8 years ago

I'm really liking Semanticolor, however my main issue with it is that it's not very useful when it comes to template literal colouring.

By default, the template literal uses the my theme's styling, which marks what's in the ${} of a template literal, however, I lose out on the colourisation of those same variables that I'm using elsewhere. Alternatively, I can restore that functionality by colourising strings, but that just runs them into a jumble of colours, which is no good for a plethora of other reasons.

Support for the colourisation of variables within template literal interpolation blocks would be extremely useful.

Theme colouring screen shot 2016-10-20 at 10 16 30

Colourisation colouring screen shot 2016-10-20 at 10 18 40

sharedprophet commented 8 years ago

Thanks. I'll look into this soon.

sharedprophet commented 8 years ago

What JavaScript grammar are you using?

davidsharp commented 8 years ago

I'm using the ES6 Babel grammar.

davidsharp commented 8 years ago

It's gandm's language-babel specifically.

sharedprophet commented 8 years ago

Fixed in 3.4.0.