search

digitallyserviced / semanticolor

Provide Atom editor with semantic color highlighting.
https://atom.io/packages/semanticolor
MIT License
34 stars 3 forks source link

Option to fill entire BG when 'contrast'? #25

Open indfnzo opened 7 years ago

indfnzo commented 7 years ago

Pardon the title, it's a little hard explaining this in a phrase.

Is it possible to make the highlighter highlight the entire line (e.g: the current line highlighter) of scopes set to contrast?

screen

See: black contrasted comment looks bad (black background is too tight).

It would be great if it would highlight the entire line instead (like the current line highlighter, see: yellow).

Thanks, I hope my issue made sense. :)

sharedprophet commented 7 years ago

Unfortunately the highlighter does not allow for altering the text color. We could combine it with scopes for the text color, but there could be non-comment text on the same line as a comment, so naively highlighting the entire line wouldn't work. How would you want it to look in that case?

indfnzo commented 7 years ago

I was actually thinking about something like this:

But then I realized it might be too much trouble given the benefit it would bring. If there would be at least some way to not make the contrasted comments look cut off (add some padding of some sort), I'd be satisfied with that :)

sharedprophet commented 7 years ago

I'll see what I can do.