search

digitallyserviced / semanticolor

Provide Atom editor with semantic color highlighting.
https://atom.io/packages/semanticolor
MIT License
34 stars 3 forks source link

Fix registry.startIdForScope is not a function for 1.24.0-beta3 #27

Closed paradoxxxzero closed 6 years ago

paradoxxxzero commented 6 years ago

This commit https://github.com/atom/atom/commit/9006d05d4f04f17b9bf96ca9a7d5fa8fdd97afdd removes the inheritance from textmateRegistry and wrap it instead. startIdForScope and endIdForScope are not proxified hence that fix.

paradoxxxzero commented 6 years ago

Could you release? (It's backward compatible)

sharedprophet commented 6 years ago

Yes, sorry. Been sick and my main computer is currently not working. I'll release it now.

paradoxxxzero commented 6 years ago

No problem, get well soon. (On a side note, I think the issue when the grammar is not always applied at start is back.)

sharedprophet commented 6 years ago

Hmm, I haven't had a problem with it. Do you have any idea what conditions might trigger it?

paradoxxxzero commented 6 years ago

Using the 1.24.0-beta3 and having lot of open tabs some open tabs.

My TextEditors have the NullGrammar. I'm going to look into what's happening.

paradoxxxzero commented 6 years ago

Ok this is a conflict with language-babel, only happen on jsx files. I'll investigate some more.

paradoxxxzero commented 6 years ago

Okay forget it it's worse than that, it seems something broke on the grammar initialisation level in the beta. I'm getting the problem on a fresh atom installation (without semanticolor).