search

digitalmaas / serverless-plugin-browserifier

Reduce the size and speed up your Node.js based lambda's using browserify.
Other
27 stars 4 forks source link

disable: true not working #12

Closed kvarela closed 4 years ago

kvarela commented 5 years ago

I get the following failure when I try to set disable: true:

$ yarn clean && serverless deploy -v --stage prod
$ (rm -r ./.build || echo "") && (rm -r ./.serverless || echo "") && (find ./src -name '*.js' -delete || echo "")
rm: ./.build: No such file or directory

Serverless: Browserifier: unexpected failure detected

  Serverless Error ---------------------------------------

  custom.browserify.disable is true in serverless.yml

  Get Support --------------------------------------------
     Docs:          docs.serverless.com
     Bugs:          github.com/serverless/serverless/issues
     Issues:        forum.serverless.com

  Your Environment Information -----------------------------
     OS:                     darwin
     Node Version:           11.1.0
     Serverless Version:     1.30.1

Here's my browserify setup for reference:

custom:
    browserify:
        disable: true
        basedir: ./
        entries: ['src/handlers/graphql.ts']
        exclude:
            - envkey
            - dotenv
            - glob
            - fs.realpath
            - minimatch
            - brace-expansion
            - concat-map
            - balanced-match
            - inherits
            - path-is-absolute
            - inflight
            - wrappy
            - once
        require:
            - node_modules/envkey
            - node_modules/dotenv
            - node_modules/glob
            - node_modules/fs.realpath
            - node_modules/minimatch
            - node_modules/brace-expansion
            - node_modules/concat-map
            - node_modules/balanced-match
            - node_modules/inherits
            - node_modules/path-is-absolute
            - node_modules/inflight
            - node_modules/wrappy
            - node_modules/once
        node: true
        debug: true
        extensions: ['.ts']
        plugin:
            - tsify
nolde commented 5 years ago

That seems like a bug. I will investigate soon.

nolde commented 4 years ago

:tada: This issue has been resolved in version 2.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: