search

digitalmaas / serverless-plugin-browserifier

Reduce the size and speed up your Node.js based lambda's using browserify.
Other
27 stars 4 forks source link

chore: update archiver #23

Closed fdionisi closed 4 years ago

fdionisi commented 4 years ago

A few days ago we started noticing our build to fail due to the following error:

TypeError: Cannot read property 'pipesCount' of undefined
    at ReadStream.Readable.pipe (_stream_readable.js:642:17)
    at Readable.<anonymous> (/codebuild/output/src218547715/src/node_modules/lazystream/lib/lazystream.js:33:12)
    at Readable.instance.<computed> (/codebuild/output/src218547715/src/node_modules/lazystream/lib/lazystream.js:18:14)
    at Readable.read (/codebuild/output/src218547715/src/node_modules/readable-stream/lib/_stream_readable.js:443:10)
    at resume_ (/codebuild/output/src218547715/src/node_modules/readable-stream/lib/_stream_readable.js:790:12)
    at processTicksAndRejections (internal/process/task_queues.js:84:21)
    at runNextTicks (internal/process/task_queues.js:66:3)
    at processImmediate (internal/timers.js:429:9)
    at process.topLevelDomainCallback (domain.js:137:15)

Enabling SLS_DEBUG=* we noticed that this error was thrown by archiver during the zip step.

Since the code always worked for the past 2 years, I simply tried updating "archiver" dependency to the latest published version and that indeed fixed this issue.

nolde commented 4 years ago

Thanks mate! I'll merge it, update a few more dependencies later today, and get a new version out!.

nolde commented 4 years ago

:tada: This PR is included in version 2.3.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: