digitalmethodsinitiative / 4cat

The 4CAT Capture and Analysis Toolkit provides modular data capture & analysis for a variety of social media platforms.
Other
246 stars 59 forks source link

proposed fix to results filter #417

Closed dale-wahl closed 6 months ago

dale-wahl commented 6 months ago

The filter excludes Zeeschuimer imports because of this line: https://github.com/digitalmethodsinitiative/4cat/blob/b930b6e964b460ef5160398c6cd1038f766b0548/webtool/views/views_dataset.py#L149 (zeeschuimer imports fail the "has_worker" check). If changed, they would have appeared as "(Near) Real-time". I created a "Zeeschuimer imports" and realized the checks in datasource-select.html do not work in general. The is_static attribute does not appear to exist. We are dealing with metadata as opposed to actual classes in this case. I can use the "importable" attribute and did so here. Static datasources still appear as "(Near) Real-time" and I do not have any attributes to decipher that without instantiating all the datasources. Maybe they are somewhere already... regardless, we do not have many static datasources (8kun and...?).

I am not sure the best way to figure out why datasources is being filtered since these templates are all importing other html components and my attempts on tracking down all instances of datasources did not feel comprehensive. So requesting review. Zeeschuimer imports do not "have_options" either and that was required.