Change media file get function and add status column

digitalmethodsinitiative / dmi-tcat

Digital Methods Initiative - Twitter Capture and Analysis Toolset

Apache License 2.0

367 stars 114 forks source link

Change media file get function and add status column #290

Closed ninthday closed 4 years ago

ninthday commented 6 years ago

Changed file_get_contents function to curl for more security
Add Status column in the media table to save http status

ninthday commented 6 years ago

I change media file get function and add status column to the media table.

dentoir commented 6 years ago

Hi @ninthday

Thanks for your contribution. However, I can't merge this yet as I don't want to add the status column to the media table on the fly. I'd prefer to use the standard upgrade path which is defined in common/upgrade.php.

If you're willing to work on this again, that'd be great. I'll be back the first week of January to merge any code.

ninthday commented 6 years ago

Hi, @dentoir

Thank you for your suggestion. Because I did not save all bin's media, so add the status column only in bin_media which we needed. I will look at common/upgrade.php during this time. Thanks again and wish you a happy holiday~

niczem commented 4 years ago

I close this PR because there haven't been any updates since 2017. Please reopen if this PR still should be merged.