markdown-it emoji plugin

digitalmoksha / motion-markdown-it-plugins

Plugins for the motion-markdown-it gem

MIT License

1 stars 1 forks source link

Closed neumayr closed 6 years ago

neumayr commented 6 years ago

markdown-it emoji plugin Ported from the javascript version. Synced with v1.4.0.

🤓huge thanks to @digitalmoksha ✨awesome work 🚀

Closes #3

neumayr commented 6 years ago

Awesome, first I was confused because locally some old test failed to run. 👏 But now I see they also fail on Travis 🙈

digitalmoksha commented 6 years ago

@neumayr yes, there are a couple tests in the other plugins that I've been unable to track down, but it's a couple edge cases.

I think the emoji plugin should be done, just updated the readme. Take a look - if everything looks good i'll accept the pull request and merge it!

neumayr commented 6 years ago

Awesome work, Thank you for this one 🙇

I've just had some small bits, you can decide on.