search

digitalnature / php-ref

A better alternative to print_r / var_dump
347 stars 59 forks source link

Updated Date-, File-Detection, etc. #39

Open matze-berg opened 8 years ago

matze-berg commented 8 years ago

Loved your work. PHP-Ref is really good in some points. But still sucks with Date & File detection. So many dumps will mark a String as Date or File, or a File as String. I have changed this, send you a request and there is nothing. You still have the wrong detection. So i think i will create a own one or switch to kint or krumo. But thanks for your good work.

ghost commented 7 years ago

php-ref beats them all

jcmarchi commented 5 years ago

Based on what I've seen, seems like you decided to adjust the code style and add many "{" and "}", indentations and line spacing commonly only required for code readability. Not that it is wrong - when it is your code - but in terms of Git, it will cause flags to pretty much everything, resulting in changed or added/removed lines that are in fact the same. As a result, it is now virtually impossible to detect the actually changes you are proposing in the original code...

Maybe you would like to consider modifying only the pieces that actually make sense for your changes to be reviewed, leaving the rest unaltered? Just my two cents.

I'd love to try your proposed changes myself, but I am not much fond of replacing the entire file.

Thanks for the effort, BTW. :)