search

digitalnodecom / node-red-contrib-generic-s3

Generic S3 nodes for use in Node-RED
https://www.npmjs.com/package/@digitalnodecom/node-red-contrib-generic-s3
Apache License 2.0
3 stars 5 forks source link

add Move Object node #43

Closed KIKOmanasijev closed 1 year ago

KIKOmanasijev commented 1 year ago

This PR implements a 'Move Object' node.

The move node simply copies an S3 object from one location to another, and then removing the original object from the old location.

trajche commented 1 year ago

Thanks @KIKOmanasijev

Some questions, does this move an object:

And secondly:

rristov60 commented 1 year ago

Thanks @KIKOmanasijev, in addition to @trajche's questions I took a look at the code and I have some suggestions for the code base, which will be left in the review

KIKOmanasijev commented 1 year ago

Thanks @KIKOmanasijev

Some questions, does this move an object:

  • between S3 instances with different credentials?
  • between different S3 buckets?
  • between different S3 folders/paths?

And secondly:

  • does this do two operations, copy + delete?

  1. between S3 instances with different credentials?

    • Nope, this node is intended to be used for moving objects between different locations in a single S3 instance.

  2. between different S3 buckets?

    • Yes, you can move objects from one bucket to another.

  3. between different S3 folders/paths

    • Yes, you can move objects between different folders/paths - in same bucket or different buckets.
KIKOmanasijev commented 1 year ago

@rristov60 I've resolved most of the issues/suggestions. Can you take another look at the new commits?