digitalnsw / nsw-design-system

The NSW Design System is a toolkit of style, patterns, standards and guidance for everyone creating distinctly NSW digital products and services. It helps us create unified, trusted, inclusive and audience centered digital experiences for our users that are clearly simple, current and purposeful.
https://designsystem.nsw.gov.au
MIT License
58 stars 30 forks source link

Add typings #476

Closed whitneyit closed 1 month ago

whitneyit commented 1 month ago

This PRs adds support for TypeScript typings to be generated alongside the existing starterkit:build command.

Also, this PR updates the entry point in package.json to the correct value of dist/js/main.js as opposed to the current, incorrect, value of dist/main.js which does not exist.

whitneyit commented 1 month ago

Hi, It appears that there is a problem with the authentication when deploying to staging?

oisa commented 1 month ago

Hi @whitneyit - the action that is failing is relating to the staging env not authorising your user for staging only. Going to merge this today.

As from your email that you had sent through, thank you for reaching out and for submitting the pull request - we really appreciate the initiative you’ve taken to address the issues with TypeScript support and the entry point exports in the NSW Design System.

whitneyit commented 1 month ago

Thank you @oisa for merging this in 😄

oisa commented 1 month ago

You're most welcome @whitneyit - thanks so much for being part of the NSW Design System and for offering up your suggestions to make the design system better for all :)