search

digitalocean / Kubernetes-Starter-Kit-Developers

Hands-on tutorial and Automation stack for an operations-ready DigitalOcean Kubernetes (DOKS) cluster.
761 stars 263 forks source link

Add note to chapter 3 Readme that chapter 4 assumes you selected Amassador #167

Closed CalRobert closed 2 years ago

CalRobert commented 2 years ago

I would have liked to know that ch. 4 assumes you used Ambassador before making my selection for Ch. 3

bikram20 commented 2 years ago

@CalRobert Thank you, and a great observation. I think we meant to use the Ambassador edge stack metrics (in chapter 4) as an example, but it does reflect as if it is a mandatory requirement.

I would actually prefer to add the example of NGINX metrics and logs in chapter 4 and 5 respectively - in addition to Ambassador.

@v-bpastiu Please fix these in the next iteration.

CalRobert commented 2 years ago

Thanks - would love to see Nginx added but this is my first time through!

v-bpastiu commented 2 years ago

Hi and thanks for the contribution. We will enhance the starter kit to include both services.

v-bpastiu commented 2 years ago

Hi, we have made some changes to the starter kit in relation to chapter 4. We have included the use of a sample app from here (https://github.com/digitalocean/kubernetes-sample-apps/tree/master/emojivoto-example) with regards to monitoring and removed the ambassador examples. Please see this PR with the changes made. https://github.com/digitalocean/Kubernetes-Starter-Kit-Developers/pull/172

Thanks