search

digitalocean / Kubernetes-Starter-Kit-Developers

Hands-on tutorial and Automation stack for an operations-ready DigitalOcean Kubernetes (DOKS) cluster.
745 stars 258 forks source link

Update `..-proxy-protocol` from `true` to `"true"` #90

Closed takotab closed 2 years ago

takotab commented 2 years ago

From the docs:

You have to supply the value as string (ex. "true", not true), otherwise you might run into a k8s bug that throws away all annotations on your Service resource.

https://github.com/kubernetes/kubernetes/issues/59113

I'm not sure if this is correct, since it still does not fixes my problems, but it seems to be a discrepancy between the docs and the starter-kit.

v-ctiutiu commented 2 years ago

@takotab Thank you for the fix !