digitalocean / clusterlint

A best practices checker for Kubernetes clusters. 🤠
Apache License 2.0
547 stars 45 forks source link

Allow images on docker.io without 'library' #104

Closed stephenpaulger closed 3 years ago

stephenpaulger commented 3 years ago

For the check fully-qualified-image the function reference.ParseAnyReference is used to discover how docker will interpret a container image reference, for images on docker hub that are official images it results in a reference like docker.io/library/busybox:1.2.3 but another valid fully qualified reference would be docker.io/busybox:1.2.3.

This change adds a test to check that docker.io/busybox:1.2.3 gives no warnings and adds a function for comparing image references that takes the optional nature of "library" into account.

stephenpaulger commented 3 years ago

I'm not certain that docker.io/busybox is fully qualified now, so closing this.