Add webhook check for timeouts - Githubissues

digitalocean / clusterlint

A best practices checker for Kubernetes clusters. 🤠

Apache License 2.0

542 stars 45 forks source link

Add webhook check for timeouts #85

Closed MorrisLaw closed 4 years ago

MorrisLaw commented 4 years ago

Creating another PR to try and trigger CircleCI, or debug further why it's not working for me. Here's the original PRs that I've closed in favor of this one: https://github.com/digitalocean/clusterlint/pull/83, https://github.com/digitalocean/clusterlint/pull/84

What This PR adds an admission controller webhook check that looks at the TimeoutSeconds value to see if it is above the max of 30 seconds.

Add a check to verify that webhook timeouts aren't greater than or equal to 30
Update docs to include Admission Controller Webhook Timeout check with fix
Update file naming to be more consistent for admission controller webhooks
Fix typo in webhook replacement struct name

Why customers should be notified if they are above the recommended TimeoutSeconds max, because this blocks upgrades.

MorrisLaw commented 4 years ago

Same changes as the https://github.com/digitalocean/clusterlint/pull/83 PR, but I closed that older one and opened this one. In an attempt to trigger CircleCI @varshavaradarajan @waynr @adamwg