search

digitalocean / clusterlint

A best practices checker for Kubernetes clusters. 🤠
Apache License 2.0
542 stars 45 forks source link

Update k8s dependencies to 0.18.3 #86

Closed varshavaradarajan closed 4 years ago

varshavaradarajan commented 4 years ago

@timoreimann , @adamwg - the k8s.io/apimachinery dependency requires go 1.13 or above as it uses errors.Is, which is supported in go 1.13. So, in order to support k8s 0.18.3 packages, we would need to upgrade go to at least 1.13.

However, I believe that clusterlint can also be consumed as a library which means that we could potentially break users if we started to use 1.14+ only features.

Can't people vendor clusterlint v0.2.0 or below if they choose not to use go 1.13 or above?

timoreimann commented 4 years ago

Bumping the Go version for error.Is sounds reasonable to me since we might eventually want to support Kubernetes 1.18-related features in clusterlint.

And yes, users stuck with Go 1.12 can continue to consume v0.2.0. They won't be able to take advantage of any features we add later on, but I believe that's a fair trade off we can make.