digitalocean / clusterlint

A best practices checker for Kubernetes clusters. 🤠
Apache License 2.0
542 stars 45 forks source link

Add resource requirements check to doks group #96

Closed varshavaradarajan closed 3 years ago

varshavaradarajan commented 3 years ago

The resource-requirements check is in the basic group right now. However, many of doks users face resource contention issues because they may not have followed this best practice of setting resource limits on their pods. We currently run all the checks in the doks group before an upgrade. We can show this warning to users if this check is added to the doks group as well.

fish-dango commented 3 years ago

Hello @varshavaradarajan! I can try this out

Any pointers for this?

varshavaradarajan commented 3 years ago

@fish-dango - thanks for your interest! :) The resource-requirements check is already added to the basic group here: https://github.com/digitalocean/clusterlint/blob/master/checks/basic/resource_requests.go#L40, you can add doks to the slice there.

varshavaradarajan commented 3 years ago

fixed via #120