digitalocean / digitalocean-cloud-controller-manager

Kubernetes cloud-controller-manager for DigitalOcean (beta)
Apache License 2.0
527 stars 149 forks source link

[do-loadbalancer-name] doesn't seem to be working #322

Closed xzilja closed 4 years ago

xzilja commented 4 years ago

Adding following lines in yaml config doesn't seem to be setting load balancer name correctly

  annotations:
    service.beta.kubernetes.io/do-loadbalancer-name: "development-graphql-lb"

Load balancer is still created with random name a[uid]

timoreimann commented 4 years ago

@IljaDaderko the feature to name LBs through an annotation was only added in our latest CCM release v0.1.24. If you use DigitalOcean's managed Kubernetes service, you should be able to benefit from all features and bug-fixes shipping with CCM v0.1.24 in the next batch of DOKS releases. For self-managed clusters, you should make sure that you run this very CCM version.

If you think you do run the right version but it's not working as intended, please let us know.

xzilja commented 4 years ago

Ah, I see. I am indeed on managed one

timoreimann commented 4 years ago

@IljaDaderko FYI, we just released a batch of DOKS versions that ship the feature you were looking for. 🎉 See our change log for details.

aholbreich commented 4 years ago

@timoreimann i would like to reuse loadbalancer with severla services... My plan was to add the same name... service.beta.kubernetes.io/do-loadbalancer-name: "lb1"

however it worked in a way: 1) the existing LB was renamed to lb1 2) the second service has initiated the creation of second LB with generated name. And this second loadbalancer is completely in crazzy status. I can't even delete that.

Expected behaviour.:

timoreimann commented 4 years ago

@aholbreich would you mind creating a new issue with more details on what you'd like to do (i.e., what your use case is), what you tried, and what ended up happening? Thanks!

aholbreich commented 4 years ago

@timoreimann - i've just learned i cannot configure several LB listeners for one and same port (443) differ only by domain. So if 443 is already has one rule, no second is possible even if another certificate is given. This seem to be limitation of DO LB, the UI don't let me do this. The docu was not precise about this. So looks like it's not limitation of this project, so no need for new issue here. Sorry for disturbance.