search

digitalocean / digitalocean-cloud-controller-manager

Kubernetes cloud-controller-manager for DigitalOcean (beta)
Apache License 2.0
524 stars 147 forks source link

Update README.md #510

Closed ayrotideysarkar closed 2 years ago

ayrotideysarkar commented 2 years ago

is this okay now? can you please merge my pull request?

timoreimann commented 2 years ago

Could you please close this PR and instead update the initial one you created at #509? There's no need to create separate PRs for addressing suggestions.

ayrotideysarkar commented 2 years ago

I have closed my previous PR, So can you merge this PR?

ayrotideysarkar commented 2 years ago

Can you please accept my PR?

On Tue, 30 Aug, 2022, 12:35 pm Timo Reimann, @.***> wrote:

Could you please close this PR and update the initial one you created? There's no need to create separate PRs for addressing suggestions.

— Reply to this email directly, view it on GitHub https://github.com/digitalocean/digitalocean-cloud-controller-manager/pull/510#issuecomment-1231237340, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASKQVJAXXO734EASEONZ5A3V3WXEZANCNFSM6AAAAAAQACWRQY . You are receiving this because you authored the thread.Message ID: <digitalocean/digitalocean-cloud-controller-manager/pull/510/c1231237340@ github.com>

timoreimann commented 2 years ago

It'd be ideal if you could close out this PR, reopen the original one, and address the comments there for the sake of continuity of the review process.

ayrotideysarkar commented 2 years ago

Done. now can you merge it?

On Thu, 1 Sept 2022 at 14:44, Timo Reimann @.***> wrote:

It'd be ideal if you could close out this PR, reopen the original one, and address the comments there for the sake of continuity of the review process.

— Reply to this email directly, view it on GitHub https://github.com/digitalocean/digitalocean-cloud-controller-manager/pull/510#issuecomment-1233994802, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASKQVJEGGTXRMEARZENCYH3V4BXYVANCNFSM6AAAAAAQACWRQY . You are receiving this because you authored the thread.Message ID: <digitalocean/digitalocean-cloud-controller-manager/pull/510/c1233994802@ github.com>