search

digitalocean / digitalocean-cloud-controller-manager

Kubernetes cloud-controller-manager for DigitalOcean (beta)
Apache License 2.0
524 stars 147 forks source link

load balancers: multiple fixes and updates #566

Closed anitgandhi closed 1 year ago

waynr commented 1 year ago

I just opened #567 after receiving a report from a customer that an annotation set which looks like

    service.beta.kubernetes.io/do-loadbalancer-certificate-id: <certificate-id>
    service.beta.kubernetes.io/do-loadbalancer-http-ports: '80'
    service.beta.kubernetes.io/do-loadbalancer-http3-port: '443'
    service.beta.kubernetes.io/do-loadbalancer-protocol: http3

was failing with an error that looked like

Error syncing load balancer: failed to ensure load balancer: failed to build load-balancer request: invalid protocol "http3" specified in annotation "service.beta.kubernetes.io/do-loadbalancer-protocol"

But then I noticed this PR, which could potentially be a better fit for that fix. Just FYI, happy to keep my PR open and follow it through.

anitgandhi commented 1 year ago

@waynr your PR is fine as-is , I think it's largely orthogonal to mine 👍

anitgandhi commented 1 year ago

@timoreimann good catch; fixed!